Allow GPUTexture where GPUTextureView is used #4407
Draft
+43
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
requested changes
Jun 25, 2025
| @@ -62,7 +62,8 @@ class F extends AllFeaturesMaxLimitsGPUTest { | |||
| texture: GPUTexture, | |||
| textureViewDescriptor?: GPUTextureViewDescriptor | |||
| ): GPURenderPassColorAttachment { | |||
| const view = texture.createView(textureViewDescriptor); | |||
| const { bindTextureResource = false } = this.params as { bindTextureResource?: boolean }; | |||
There was a problem hiding this comment.
I think I might be better to just pass in bindTextureResource? This is not type safe. If the parameters change, this will still compile, it will just always be false.
There was a problem hiding this comment.
I did that because textureViewDescriptor was optional. Maybe I should update getColorAttachment parameters with something like getColorAttachment(texture, {textureViewDescriptor, bindTextureResource}) instead...
There was a problem hiding this comment.
@greggman I've fixed this in latest commit.
| @@ -76,7 +77,8 @@ class F extends AllFeaturesMaxLimitsGPUTest { | |||
| texture: GPUTexture, | |||
| textureViewDescriptor?: GPUTextureViewDescriptor | |||
| ): GPURenderPassDepthStencilAttachment { | |||
| const view = texture.createView(textureViewDescriptor); | |||
| const { bindTextureResource = false } = this.params as { bindTextureResource?: boolean }; | |||
beaufortfrancois
force-pushed
the
use-texture
branch
2 times, most recently
from
3f4bf23 to
a4b0960
Compare
beaufortfrancois
force-pushed
the
use-texture
branch
from
a4b0960 to
7e20a09
Compare
greggman
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec PR: gpuweb/gpuweb#5228
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.